Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled missing Tree title button font and font size theme settings #79165

Merged

Conversation

Koyper
Copy link
Contributor

@Koyper Koyper commented Jul 7, 2023

For Tree, this PR enables the existing theme cache settings (apparently as placeholders) for title_button_font and title_button_font_size.

title_button_font could be set but didn't do anything, and title_button_font_size did not have an exposed theme setting.

@RedworkDE RedworkDE added this to the 4.x milestone Jul 7, 2023
@YuriSizov YuriSizov modified the milestones: 4.x, 4.2 Jul 7, 2023
@Koyper Koyper force-pushed the enable_missing_tree_title_font_settings branch from bb5df68 to dd19e3e Compare July 7, 2023 17:10
@Koyper Koyper marked this pull request as ready for review July 7, 2023 17:20
@Koyper Koyper requested review from a team as code owners July 7, 2023 17:20
Copy link
Member

@KoBeWi KoBeWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs rebase.

@Koyper Koyper force-pushed the enable_missing_tree_title_font_settings branch from dd19e3e to bf7b05e Compare August 16, 2023 13:00
@Koyper Koyper force-pushed the enable_missing_tree_title_font_settings branch from bf7b05e to e845889 Compare August 16, 2023 13:10
@akien-mga akien-mga merged commit e31cb25 into godotengine:master Aug 16, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@Koyper Koyper deleted the enable_missing_tree_title_font_settings branch September 5, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants