Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a warning about C# differences to the class reference #79206

Merged
merged 1 commit into from
Jul 14, 2023
Merged

Add a warning about C# differences to the class reference #79206

merged 1 commit into from
Jul 14, 2023

Conversation

raulsntos
Copy link
Member

Adds a warning to the class reference documentation for classes that have notable1 differences between GDScript and C#.

Footnotes

  1. By notable I mean important enough to be mentioned explicitly in the C# API differences to GDScript documentation page. ↩

@raulsntos raulsntos added this to the 4.x milestone Jul 8, 2023
@raulsntos raulsntos requested a review from a team as a code owner July 8, 2023 14:10
raulsntos
raulsntos commented Jul 8, 2023
View reviewed changes
doc/tools/make_rst.py Outdated Show resolved Hide resolved
@akien-mga
Copy link
Member

Would it be worth extending EditorHelp to do the same? (Possibly only when MODULE_MONO_ENABLED)

@raulsntos
Copy link
Member Author

I think so yes. Unfortunately we don't support [note] in EditorHelp (yet1).

Footnotes

  1. https://github.com/godotengine/godot/pull/63079. ↩

@raulsntos raulsntos force-pushed the doc-mention-csharp-differences branch from c231d84 to f1a1a29 Compare July 8, 2023 17:03
@akien-mga akien-mga mentioned this pull request Jul 8, 2023
Draft
akien-mga
akien-mga reviewed Jul 8, 2023
View reviewed changes
editor/editor_help.cpp Outdated Show resolved Hide resolved
@raulsntos raulsntos force-pushed the doc-mention-csharp-differences branch from f1a1a29 to 4997b63 Compare July 8, 2023 23:26
@raulsntos raulsntos mentioned this pull request Jul 8, 2023
Merged
@raulsntos raulsntos force-pushed the doc-mention-csharp-differences branch from 4997b63 to a164e3e Compare July 8, 2023 23:44
@akien-mga akien-mga modified the milestones: 4.x, 4.2 Jul 10, 2023
@YuriSizov YuriSizov mentioned this pull request Jul 14, 2023
Closed
@YuriSizov YuriSizov merged commit 0231611 into godotengine:master Jul 14, 2023
13 checks passed
@YuriSizov
Copy link
Contributor

Thanks!

@raulsntos raulsntos deleted the doc-mention-csharp-differences branch July 14, 2023 18:38
@YuriSizov YuriSizov changed the title Add a warning about C# differences in classref doc Add a warning about C# differences to the class reference Jul 19, 2023
@raulsntos raulsntos mentioned this pull request Jan 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
documentation enhancement topic:dotnet
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

PoolVector3Array is missing from Mono
3 participants
@raulsntos @akien-mga @YuriSizov