Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GDScript: Properly track extents of constants #79301

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

vnen
Copy link
Member

@vnen vnen commented Jul 10, 2023

Even in the case of errors.

Note: I did a check across the parser to see if any other of these would be missing and didn't find anything. I won't mind if someone else wants to double check.

Bugsquad edit: Issue linked.

@vnen vnen added bug topic:gdscript cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release labels Jul 10, 2023
@vnen vnen added this to the 4.2 milestone Jul 10, 2023
@vnen vnen requested a review from a team as a code owner July 10, 2023 17:16
@dalexeev
Copy link
Member

Note: I did a check across the parser to see if any other of these would be missing and didn't find anything. I won't mind if someone else wants to double check.

I found one more:

if (expression == nullptr) {
push_error(R"(Expected expression for match pattern.)");
return nullptr;

complete_extents(pattern);

@vnen vnen force-pushed the gdscript-const-complete-extents branch from 606c39e to cbfe2b6 Compare July 12, 2023 13:57
@vnen
Copy link
Member Author

vnen commented Jul 12, 2023

Updated to include @dalexeev's find. Thanks!

@YuriSizov YuriSizov merged commit 6c4f85a into godotengine:master Jul 12, 2023
13 checks passed
@YuriSizov
Copy link
Contributor

Thanks!

@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.2.

@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Aug 31, 2023
@vnen vnen deleted the gdscript-const-complete-extents branch October 19, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants