Add a test suite for TranslationServer #79317
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azuloo
force-pushed
the
translation-server-test-suit
branch
from
52cc7f7 to
e7c3ffe
Compare
akien-mga
changed the title
|
I've fixed formatting issues and removed unneeded includes. Also squished 2 commits into one. There's also a typo in my commit message ('suit' -> 'suite'), should I change it? |
AThousandShips
requested changes
Jul 11, 2023
| int l_count_before = ts->get_loaded_locales().size(); | ||
| ts->add_translation(t); | ||
| int l_count_after = ts->get_loaded_locales().size(); | ||
| // Newly created Translation object should be added to the list, so the counter should increase, too |
There was a problem hiding this comment.
Suggested change
| // Newly created Translation object should be added to the list, so the counter should increase, too | |
| // Newly created Translation object should be added to the list, so the counter should increase, too. |
Comments should start with a capital and end with a period, same elsewhere
|
|
||
| CHECK(res == loc); | ||
|
|
||
| // No such variant in variant_map; should return everyting except the variant |
There was a problem hiding this comment.
Suggested change
| // No such variant in variant_map; should return everyting except the variant | |
| // No such variant in variant_map; should return everything except the variant |
|
Go ahead and update the commit message spelling when fixing the issues |
azuloo
force-pushed
the
translation-server-test-suit
branch
from
e7c3ffe to
ef155c1
Compare
|
You accidentally reset your branch to |
|
Superseded by #79331. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A test suit that covers
TranslationServer, see #43440 for more details.