Fix ProjectSettings::localize_path for Windows paths
#79342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems like we have tests for |
RedworkDE
force-pushed
the
localize-win-path
branch
from
cebdf83 to
2ea2f3a
Compare
RedworkDE
commented
Jul 15, 2023
| CHECK_EQ(ProjectSettings::get_singleton()->localize_path("path/./filename"), "res://path/filename"); | ||
| CHECK_EQ(ProjectSettings::get_singleton()->localize_path("path\\.\\filename"), "res://path/filename"); | ||
|
|
||
| // FIXME?: These checks pass, but that doesn't seems correct |
There was a problem hiding this comment.
These have passed before as well, this behavior isn't new. Only the last 4 checks are actually affected by this PR.
RedworkDE
force-pushed
the
localize-win-path
branch
from
2ea2f3a to
66000f4
Compare
RedworkDE
force-pushed
the
localize-win-path
branch
from
66000f4 to
aee1e50
Compare
This was referenced Jul 30, 2023
bruvzg
approved these changes
Aug 7, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GD.PushErrorandGD.PushWarning#79280 (comment)If a path with
\was passed in it would never be recognized as being in the resource path and never become a local path. Thus move thesimplify_pathearlier to fix that. (The replace call is unnecessary because simplify_path already does that)(Tbh there are probably still edge cases where something like this can happen esp when involving symlinks or such)