[macOS] Add about_to_open and popup_hide callback for the global menus.

[bruvzg]

• Adds about_to_open and popup_hide callback for the global menus
• Move part of logic to the PopupMenu to allow live menu modification

Fixes #79349

[Riteo]

Actually, if I'm understanding correctly, a popup_hide DisplayServer callback would be great for popups in general because on Wayland popups close by themselves when unfocusing or something else like locking the screen, resorting me to force a WINDOW_EVENT_CLOSE_REQUEST to them hoping that they get cleaned up.

That said, I have no idea how much the global menu logic differs from normal window logic so I have no idea if this is possible.

[bruvzg]

Actually, if I'm understanding correctly, a popup_hide DisplayServer callback would be great for popups in general because on Wayland popups close by themselves when unfocusing or something else like locking the screen, resorting me to force a WINDOW_EVENT_CLOSE_REQUEST to them hoping that they get cleaned up.

Global menu do not use any of the window logic. Popup auto closeing on the rest of the platforms do the same, send WINDOW_EVENT_CLOSE_REQUEST.

[Riteo]

@bruvzg

Global menu do not use any of the window logic. Popup auto closeing on the rest of the platforms do the same, send WINDOW_EVENT_CLOSE_REQUEST.

Oh all right so that is the right way, nevermind, I thought for some reason that it was an hack.

Edit: Just to be clear, by hack I meant an hack in my Wayland implementation.

[brunosxs]

You need to override the global_menu_add_item() on all display servers as right now this can create lots of warnings on the console.

[bruvzg]

You need to override the global_menu_add_item() on all display servers as right now this can create lots of warnings on the console.

It should not be called on DisplayServer that doesn't support it, but one check was missing. Should be fixed now.

[akien-mga]

Thanks!