Disable irrelevant scene tab context menu items #79382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bug: |
|
Oh, so this makes an existing bug surface where the popup doesn't realize in time that by doing RMB, you changed the active scene. I have a mild memory of noticing this bug already being present for Undo Close Tab somehow. Either way, I should probably look into fixing this before the PR is acceptable |
|
I think you should use the clicked tab id instead of the current scene. |
MewPurPur
force-pushed
the
better-prepare-scene-context-menu
branch
from
9d4a13a
to
4b0ee49
Compare
|
True, doned and works |
KoBeWi
approved these changes
Aug 16, 2023
|
Thanks! |
YuriSizov
reviewed
Aug 24, 2023
Comment on lines
+5623
to
+5629
| if (editor_data.get_edited_scene_count() <= 1) { | ||
| scene_tabs_context_menu->set_item_disabled(file_menu->get_item_index(FILE_CLOSE_OTHERS), true); | ||
| } | ||
| scene_tabs_context_menu->add_item(TTR("Close Tabs to the Right"), FILE_CLOSE_RIGHT); | ||
| if (editor_data.get_edited_scene_count() == tab_id + 1) { | ||
| scene_tabs_context_menu->set_item_disabled(file_menu->get_item_index(FILE_CLOSE_RIGHT), true); | ||
| } |
There was a problem hiding this comment.
There is a typo here, right? It shouldn't be file_menu, it should be scene_tabs_context_menu.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like it's done in the script list.