Fix physics passive hovering with MOUSE_FILTER_IGNORE

[Sauermann]

When the parent SubViewportContainer ignores mouse, then the SubViewport shouldn't create mouse-move-events for passive hovering.

resolve #79441
follow-up to #78017

Updated 2023-07-18: Fix also passive hovering during Drag and Drop as mentioned in #75120 (comment)

[RandomShaper]

When parent_ignore_mouse is true, the for loop can be skipped.

[Sauermann]

I'm not entirely sure, if that is correct, because the loop covers also non-mouse events, like InputEventScreenDrag.
Skipping the loop in the case parent_ignore_mouse == true would mean, that InputEventScreenDrag-events don't get evaluated.
Also ... skipping would have the effect, that these events stay in Viewort::physics_picking_events to be executed during the next physics-frame(s).

[RandomShaper]

My point was about putting the loop inside an if because it was only used to determine if has_mouse_event should be true. If other conditions didn't meet, the value of has_mouse_event was unused. But you have already changed the code, eliminating the loop altogether, and I can't say for sure now.

[Sauermann]

Now I understand you. I was talking about a different loop, than you were.
With that in mind, I agree and will update the PR.

[RandomShaper]

Isn't the wording of the various filter modes inaccurate as they say things like "the control will not receive mouse button input [...]"? I mean, it's not only about buttons but also movement, isn't it?

[YuriSizov]

Thanks!