-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Y-sort position of the first item in the sorted subtree #79452
Update Y-sort position of the first item in the sorted subtree #79452
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tentatively approving, as the changes seem simple and I trust @kleonc's assessment. But I'm not competent on this rendering code so a review from Clay or lawnjelly would still be very welcome (but if they're busy, I'm happy to yolo merge this in a few days and we'll see in production if any edge case was forgotten).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not really sure about this code as I'm not familiar enough with the surroundings to know why the parent node was excluded from the y-sort in the first place, but I trust kleonc, so let's go ahead with a yolomerge
AFAICT the docs being incorrect about that is a result of them being simply a reworded version of the old YSort node's description when it was changed in #42282. But in that PR the canvas items with y-sort enabled were made to be included within the y-sorting themselves so it would work properly. Also by
|
Thanks! |
Fixes #79451.
Also updated the docs as Y-sorting affects not only the child nodes, the CanvasItem with
y_sort_enabled = true
is being Y-sorted together with its children (always was, in a potentially buggy manner but still).