Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have core_bind.h Thread type syntax match core_bind.cpp #79466

Merged
merged 1 commit into from
Jul 21, 2023
Merged

Have core_bind.h Thread type syntax match core_bind.cpp #79466

merged 1 commit into from
Jul 21, 2023

Conversation

Repiteo
Copy link
Contributor

@Repiteo Repiteo commented Jul 14, 2023

Changes two instances of Thread::ID to ::Thread::ID. This is functionally identical to prior implementation, but removes misattributed errors in VSCode intellisense

@Repiteo
Have core_bind.h thread type syntax match .cpp
1651c5d 
• Functionally identical to prior implementation, but removes misattributed errors in VSCode intellisense
@Repiteo Repiteo requested a review from a team as a code owner July 14, 2023 15:22
@AThousandShips AThousandShips added this to the 4.2 milestone Jul 14, 2023
@YuriSizov YuriSizov merged commit 01e0867 into godotengine:master Jul 21, 2023
@YuriSizov
Copy link
Contributor

Thanks!

@Repiteo Repiteo deleted the core_bind-header-fix branch July 21, 2023 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RandomShaper RandomShaper RandomShaper approved these changes

Assignees
No one assigned
Labels
bug topic:buildsystem topic:core
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
4 participants
@Repiteo @YuriSizov @RandomShaper @AThousandShips