Set default cell_size on new TileMap Layer navigation layer maps
#79485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smix8
added
bug
topic:navigation
topic:2d
cherrypick:4.0
cherrypick:4.1
Scony
reviewed
Jul 15, 2023
Scony
approved these changes
Jul 15, 2023
groud
approved these changes
Jul 20, 2023
YuriSizov
changed the title
cell_size on new TileMap Layer navigation layer maps
|
Hey, we're ready to merge, but this needs a rebase following #78328 🙏 |
Sets default cell_size on new TileMap Layer navigation layer maps.
smix8
force-pushed
the
tilemap_cell_size_4.x
branch
from
eb13d31 to
671839d
Compare
|
Thanks! |
YuriSizov
removed
cherrypick:4.0
cherrypick:4.1
|
So because of #78328 this cannot be easily cherry-picked to 4.1. A dedicated PR would be required if this is desired. (And I wouldn't bother with 4.0, we are unlikely to publish another 4.0.x release at this point). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets default cell_size on new TileMap Layer navigation layer maps
Related issue #79474.
This was also an issue in 4.0 but that version had no error that made users aware of it.