Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GDScript: Fix subscript resolution for constant non-metatypes #79510

Merged

Conversation

dalexeev
Copy link
Member

@dalexeev dalexeev commented Jul 15, 2023

See #79412 (comment).

Also fixes the export enums as values.

@dalexeev dalexeev added this to the 4.2 milestone Jul 15, 2023
@dalexeev dalexeev requested a review from a team as a code owner July 15, 2023 18:51
@dalexeev dalexeev force-pushed the gds-fix-const-non-metatype-subscript branch 2 times, most recently from 96dec29 to c741ad7 Compare July 15, 2023 19:28
Copy link
Member

@adamscott adamscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved during the GDScript team meeting. Thanks @dalexeev !

@dalexeev dalexeev force-pushed the gds-fix-const-non-metatype-subscript branch from c741ad7 to 5b8a6b8 Compare September 19, 2023 19:17
@dalexeev dalexeev force-pushed the gds-fix-const-non-metatype-subscript branch from 5b8a6b8 to c35cb51 Compare September 19, 2023 19:26
@akien-mga akien-mga merged commit 971f678 into godotengine:master Sep 20, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exporting an enum sourced from a Resource doesn't work.
3 participants