Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add drag'n'drop text option for LineEdit and RichTextLabel #79563

Merged

Conversation

danny88881
Copy link
Contributor

@danny88881 danny88881 commented Jul 17, 2023

Extends the functionality of #62221 to LineEdit and RichTextLabel and addresses godotengine/godot-proposals#7297

The additional changes in LineEdit are to make its behavior more similar to TextEdit and RichTextLabel when drag_and_drop_selection_enabled is set to false, with the new form mirroring TextEdit's implementation.

(first ever pull request, let me know if I've done anything wrong)

@danny88881 danny88881 requested review from a team as code owners July 17, 2023 01:03
@danny88881 danny88881 force-pushed the drag-and-drop-text-setting branch from 7d5e0d8 to fd1920d Compare July 17, 2023 01:10
@Calinou Calinou added this to the 4.x milestone Jul 17, 2023
@danny88881 danny88881 force-pushed the drag-and-drop-text-setting branch from fd1920d to c02c8b9 Compare July 17, 2023 01:35
Copy link
Member

@KoBeWi KoBeWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation comment should be addressed, otherwise seems fine.

@danny88881 danny88881 force-pushed the drag-and-drop-text-setting branch from c02c8b9 to cfe98c5 Compare July 20, 2023 02:19
@YuriSizov YuriSizov changed the title Drag and drop text setting Add drag'n'drop text option for LineEdit and RichTextLabel Jul 25, 2023
@YuriSizov YuriSizov modified the milestones: 4.x, 4.2 Jul 25, 2023
@YuriSizov
Copy link
Contributor

@danny88881 You have just merged the upstream master into your branch. If you want to update your branch with the current master you need to do a rebase instead. Your PR should only contain your own changes, and nothing else.

@danny88881 danny88881 force-pushed the drag-and-drop-text-setting branch from ad0c7af to cfe98c5 Compare July 27, 2023 16:31
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we have the feature in TextEdit, it seems to make sense to include in LineEdit and RTL too.

@akien-mga akien-mga merged commit d8cbb6d into godotengine:master Aug 2, 2023
@akien-mga
Copy link
Member

Thanks! And congrats for your first merged Godot contribution 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants