Make AnimationNodeBlendTree use RBMap instead HashMap
#79595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TokageItLab
changed the title
AnimationNodeBlendTree use RBMap insteads HashMap
fire
approved these changes
Jul 18, 2023
|
Can't you just use |
!! You are right, I didn't care that RBMap has a Comparator. It is working perfectly. So this is now a one-line change. Thanks! |
TokageItLab
force-pushed
the
rbmap-animblendtree
branch
from
348e5c7 to
29d63f4
Compare
|
That could probably have been suggested in the original PR going forward |
TokageItLab
force-pushed
the
rbmap-animblendtree
branch
from
29d63f4 to
a3cdacd
Compare
YuriSizov
approved these changes
Jul 21, 2023
|
Thanks! |
YuriSizov
changed the title
AnimationNodeBlendTree use RBMap insteads HashMapAnimationNodeBlendTree use RBMap instead HashMap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #42788. Alternative PR of #79530.
node_connectionsis stored in ordered array, but the order of the array depends on theHashMap nodes, so every time the hash is changed, the.tresis changed.This PR ensures uniqueness in the order of nodes by using an
RBMapfor nodes.However, there seems to be a problem with inconsistent insertion locations when
StringNameis used as the key forRBMap(see also #79596). Therefore,RBMap<String, Node>should be used instead ofRBMap<StringName, Node>.Although not related to this PR, if you are using
RBMap<StringName, V>in other classes, you may need to replace it withHashMap<StringName, V>orRBMap<String, V>.