-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add size check to prevent popup bigger than the screen itself #79617
Merged
akien-mga
merged 1 commit into
godotengine:master
from
sepTN:add-screensize-check-popup
Feb 18, 2024
Merged
Add size check to prevent popup bigger than the screen itself #79617
akien-mga
merged 1 commit into
godotengine:master
from
sepTN:add-screensize-check-popup
Feb 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sepTN
force-pushed
the
add-screensize-check-popup
branch
2 times, most recently
from
July 18, 2023 16:29
3eb17f7
to
8123453
Compare
sepTN
force-pushed
the
add-screensize-check-popup
branch
from
July 18, 2023 18:09
38c4961
to
8afdde8
Compare
bruvzg
reviewed
Jul 19, 2023
sepTN
force-pushed
the
add-screensize-check-popup
branch
from
July 19, 2023 12:35
b12c297
to
38095eb
Compare
Sauermann
approved these changes
Feb 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I haven't tested the PR, the changes seem to solve the linked issue and I don't see any obvious problems with the implementation.
AThousandShips
approved these changes
Feb 18, 2024
Thanks! I'll git squash to a single commit in a bit. |
sepTN
force-pushed
the
add-screensize-check-popup
branch
from
February 18, 2024 17:29
fff674f
to
34210e8
Compare
Thanks! |
akien-mga
added
cherrypick:4.2
Considered for cherry-picking into a future 4.2.x release
cherrypick:4.1
Considered for cherry-picking into a future 4.1.x release
labels
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
cherrypick:4.1
Considered for cherry-picking into a future 4.1.x release
cherrypick:4.2
Considered for cherry-picking into a future 4.2.x release
topic:editor
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add size check to prevent popup bigger than the screen itself.
Fix #78594 however I'm not sure if this is the correct way to do it. Maybe if there's someone who can point me in the right direction.
First, as per the issue #78594 to cause the freeze, have a ridiculous dialog_bounds value in your:
.godot/editor/project_metadata.cfg
Second, open your Project Settings.
Before (without this pr)
After (with this pr applied)