Fix arg count checks in SceneDebugger

[kleonc]

In #58929 args passed to SceneDebugger::parse_message were changed to no longer be fixed size. However:

• For p_msg == "live_node_call" case the error was removed, instead of modified to handle variadic arg count.
• For p_msg == "live_res_call" case the error was unchanged, instead of modified to handle variadic arg count.

This PR fixes error checking for both cases.

Fixes #79616.

[kleonc]

godot/scene/debugger/scene_debugger.cpp

Lines 179 to 187 in 0c2144d

	LocalVector<Variant> args;
	LocalVector<Variant *> argptrs;
	args.resize(p_args.size() - 2);
	argptrs.resize(args.size());
	for (uint32_t i = 0; i < args.size(); i++) {
	args[i] = p_args[i + 2];
	argptrs[i] = &args[i];
	}
	live_editor->_res_call_func(p_args[0], p_args[1], (const Variant **)argptrs.ptr(), argptrs.size());

Should for p_args.size() == 2 the call be changed to live_editor->_res_call_func(p_args[0], p_args[1], nullptr, 0) or is it fine as is?

[Faless]

Should for p_args.size() == 2 the call be changed to live_editor->_res_call_func(p_args[0], p_args[1], nullptr, 0) or is it fine as is?

Yes, I think it should be something like:

live_editor->_res_call_func(p_args[0], p_args[1], argptrs.size() ? (const Variant **)argptrs.ptr() : nullptr, argptrs.size());

[Faless]

LGTM, thanks for looking into this 🏆

[YuriSizov]

Thanks!

[YuriSizov]

Cherry-picked for 4.1.2.