Fix node duplication in scene sub-inheritance (2.1) #7978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RandomShaper
force-pushed
the
fix-sub-inheritance-2.1
branch
from
0f75b56
to
6aef1c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7976.
And hopefully doesn't break anything. Some testing won't harm.
UPDATE: Still happens sometimes. :( Not ready for merging.UPDATE: This may also fix some issues with properties of inherited nodes (and even connections and groups). Or even broken something there. If have no time to look for the improvements in that regard, so if someone finds this is fixing some issue of that kind, please report them as such.
UPDATE: With the last push most problems are solved. I'll open another issue report for the remaining cases.