Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update outdated C# code sample in AStarGrid2D documentation #79794

Merged
merged 1 commit into from
Jul 25, 2023
Merged

Update outdated C# code sample in AStarGrid2D documentation #79794

merged 1 commit into from
Jul 25, 2023

Conversation

DarthKitten2130
Copy link
Contributor

@DarthKitten2130 DarthKitten2130 commented Jul 22, 2023 •
edited by AThousandShips
Loading

This fixes a minor error in the documentation for the AStarGrid2D API C# example, replacing the now deprecated 'Size' property with the recommended 'Region' property. This encourages newcomers to the API to use the most up-to-date syntax and avoid deprecated properties.

@DarthKitten2130 DarthKitten2130 requested a review from a team as a code owner July 22, 2023 16:42
@RedworkDE RedworkDE added this to the 4.2 milestone Jul 22, 2023
@DarthKitten2130 DarthKitten2130 changed the title Updated Deprecated Method in C# Example (from Size to Region) Updated Deprecated Property in C# Example (from Size to Region) Jul 22, 2023
dalexeev
dalexeev approved these changes Jul 22, 2023
View reviewed changes
Copy link
Member

@dalexeev dalexeev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. It was my oversight, I often forget about C#. Thank you!

@dalexeev dalexeev added the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Jul 22, 2023
@DarthKitten2130
Copy link
Contributor Author

Thank you! This is my first-ever PR on a public repo lol. Ig you gotta start somewhere.

@AThousandShips
Copy link
Member

Welcome!

@YuriSizov YuriSizov changed the title Updated Deprecated Property in C# Example (from Size to Region) Update outdated C# code sample in AStarGrid2D documentation Jul 24, 2023
@YuriSizov YuriSizov merged commit 9d118c2 into godotengine:master Jul 25, 2023
@YuriSizov
Copy link
Contributor

Thanks! And congrats on your first merged Godot PR!

@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.3.

@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Oct 19, 2023
@skyace65 skyace65 mentioned this pull request Jan 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalexeev dalexeev dalexeev approved these changes

Assignees
No one assigned
Labels
documentation enhancement
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

AStarGrid2d - C# Example uses outdated property
6 participants
@DarthKitten2130 @AThousandShips @YuriSizov @dalexeev @akien-mga @RedworkDE