Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify that Callable will not be encoded with var_to_bytes #79813

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Clarify that Callable will not be encoded with var_to_bytes #79813

merged 1 commit into from
Jan 24, 2024

Conversation

AThousandShips
Copy link
Member

Only added to @GlobalScope, can add to FileAccess as well if desired, but it links there so didn't want to repeat too much

@AThousandShips AThousandShips added enhancement topic:core documentation cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release labels Jul 23, 2023
@AThousandShips AThousandShips added this to the 4.2 milestone Jul 23, 2023
@AThousandShips AThousandShips requested a review from a team as a code owner July 23, 2023 08:14
@ghost
Copy link

ghost commented Jul 25, 2023

Thank you for fixing!

@adamscott
Copy link
Member

I wonder if this should be in the Callable doc instead.

@AThousandShips
Copy link
Member Author

I'd say here or both, as you won't necessarily think to look at Callable when doing IO

@AThousandShips
Copy link
Member Author

Also the matching detail for var_to_str is here from a previous PR

@AThousandShips AThousandShips added cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release and removed topic:core labels Oct 26, 2023
@AThousandShips AThousandShips modified the milestones: 4.2, 4.3 Oct 26, 2023
@YuriSizov YuriSizov merged commit 79d8184 into godotengine:master Jan 24, 2024
15 checks passed
@AThousandShips AThousandShips deleted the callable_doc branch January 24, 2024 13:15
@YuriSizov
Copy link
Contributor

Thanks!

@AThousandShips
Copy link
Member Author

Thank you!

@YuriSizov YuriSizov removed cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Jan 24, 2024
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.2.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuriSizov YuriSizov YuriSizov approved these changes

Assignees
No one assigned
Labels
documentation enhancement
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

Callables and lambdas stored with FileAccess store_var() become null::null after get_var().
3 participants
@AThousandShips @adamscott @YuriSizov