Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if shader cache directory is available before using cache #79883

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

clayjohn
Copy link
Member

Might help: #79115

At any rate, this is necessary to allow users to turn off the shader cache.

We use shader_cache_dir_valid as a shorthand for if the shader cache is enabled and if the cache location is readable/writable in RD. we should be using the same structure here

CC @ChibiDenDen

Copy link
Member

@RandomShaper RandomShaper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

@YuriSizov YuriSizov merged commit d894a2f into godotengine:master Jul 26, 2023
13 checks passed
@YuriSizov
Copy link
Contributor

Thanks!

@clayjohn clayjohn deleted the GLES3-shader-cache-dir branch July 26, 2023 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants