Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update C# example of tween_method with a parameter to the lambda method #79962

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

viksl
Copy link
Contributor

@viksl viksl commented Jul 27, 2023

In the C# example the lambda method is missing a parameter which causes an error since the tween_method expects a method with a pass in parameter, this updates the documentation to reflect that and also uses the parameter in the lambda to match the GDScript example.

I hope I haven't messed anything, it's my first PR so please have mercy.

doc/classes/Tween.xml Outdated Show resolved Hide resolved
@viksl
Copy link
Contributor Author

viksl commented Jul 28, 2023

@RedworkDE thanks for the suggestion, the original comment felt a bit off so I just tried to suggest something but honestly wasn't sure what to do with it either heh. Is there anything I need to do now, please? I'm not familiar with this process.

@RedworkDE
Copy link
Member

Check https://github.com/godotengine/godot/blob/master/CONTRIBUTING.md and its linked docs pages for more general information about contributing.

You need to squash the two commits into one by following these instructions: https://docs.godotengine.org/en/latest/contributing/workflow/pr_workflow.html.

@viksl
Copy link
Contributor Author

viksl commented Jul 28, 2023

@RedworkDE Thanks, I tried to follow it but I'm not sure if it's ok like this or if I messed something up? Really thank you for your time.

Copy link
Member

@RedworkDE RedworkDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good now.

@YuriSizov YuriSizov changed the title [Documentation] Update C# example of tween_method in Tween class with a parameter to the lambda method. Update C# example of tween_method with a parameter to the lambda method Aug 1, 2023
@YuriSizov YuriSizov merged commit f4b6bc0 into godotengine:master Aug 1, 2023
13 checks passed
@YuriSizov
Copy link
Contributor

YuriSizov commented Aug 1, 2023

Thanks! And congrats on your first merged Godot PR!

@viksl viksl deleted the update-tween-docs branch August 1, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tween's tween_method has incorrect C# example which causes errors.
4 participants