Optimize and fix up some SVGs #80119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MewPurPur
force-pushed
the
svg-opacities-standardization
branch
from
abf53b8 to
c2aa71f
Compare
I think you meant 5 KB? 😛 |
MewPurPur
force-pushed
the
svg-opacities-standardization
branch
from
c2aa71f to
dbd3949
Compare
|
Fixed! |
MewPurPur
force-pushed
the
svg-opacities-standardization
branch
8 times, most recently
from
1cf41c2 to
401e3a2
Compare
MewPurPur
force-pushed
the
svg-opacities-standardization
branch
4 times, most recently
from
ed6cba8 to
963f456
Compare
|
Of course this went on to become more of a dumping ground for more tweaks and improvements, so it's more like 8 kB now. |
MewPurPur
force-pushed
the
svg-opacities-standardization
branch
from
963f456 to
4046609
Compare
MewPurPur
force-pushed
the
svg-opacities-standardization
branch
from
4046609 to
93318d2
Compare
Calinou
approved these changes
Aug 14, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses some icons I missed in my SVG optimization PRs. A few of them are small fix-ups, like tiny lines in the middle of arcs or unintentional elliptical arcs where they meant to be circlular. This saves about 5 kB.
Also I changed the opacity of some icons slightly. Many icons used alphas like 50 or 100. When doing 50/255 for example, it can get thrown off and become something like 0.19608 when opened in an editor. The alpha values 51, 102, 153, and 204 result in no precision inconsistencies (as they are 0.2, 0.4, 0.6, 0.8) so I used them where the change isn't noticeable. Even if it's noticeable, it's probably for the better, as some people have complained about low opacity icons. Where not applicable (e.g. an alpha value of 20, which isn't close to any of these), I changed to use at most 3 digits of precision.
^ I don't think this needs to be enforced strictly, it's just a nice thing to do once IMO, and also artists probably often copy the opacity of existing icons. (or maybe it's just me doing things like that? 😅)