Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert incorrect Rect2.expand description. #80217

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

Mickeon
Copy link
Contributor

@Mickeon Mickeon commented Aug 3, 2023

As you can see here: #69816 (comment)

I am pretty sure this change is wrong. It was specifically modified because, when expanded to the right or bottom, the to point is not included in the rectangle by the has_point. (and this is on purpose)

Agh, this reply is technically correct. Saying "expanded to include" does imply that by calling has_point with the same point on the new rectangle , the result may or may not be true. I would like to think of a way to say this in a simpler way. At worst, the description needs to be mostly reverted back.

This PR reverts the description to say "align the" with a bit of tweaking to have it match the previous changes.

Also affects Rect2i of course.

Also affects Rect2i of course.
@Mickeon Mickeon requested a review from a team as a code owner August 3, 2023 13:02
@akien-mga akien-mga requested a review from groud August 3, 2023 13:02
@akien-mga akien-mga added this to the 4.2 milestone Aug 3, 2023
@akien-mga akien-mga merged commit c97e4a3 into godotengine:master Aug 3, 2023
@akien-mga
Copy link
Member

Thanks!

@Mickeon Mickeon deleted the oops-rects branch December 30, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants