CI: Make extension API compatibility check mandatory #80220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means that any PR which breaks the extension API should handle it properly, that is: - Add compatibility methods to ensure that existing function hashes work - Document the changes in the relevant misc/extension_api_validation/ file
akien-mga
added
enhancement
topic:buildsystem
topic:gdextension
cherrypick:4.1
|
Converting to draft temporarily as I'll do some tests, once the first commit passes CI, I'll push one that should trigger errors to make sure this properly fails the CI. |
Works:
|
akien-mga
force-pushed
the
ci-api-compat-mandatory
branch
from
eca225d to
a890457
Compare
YuriSizov
approved these changes
Aug 3, 2023
|
Cherry-picked for 4.1.2. |
YuriSizov
removed
the
cherrypick:4.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means that any PR which breaks the extension API should handle it properly, that is:
misc/extension_api_validation/fileFor
4.1, we should make sure before cherry-picking that we don't actually have compatibility breakages that slipped past our watch.