Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.x] [macOS] Backport notarytool, provisioning profile and PKG export options. #80239

Merged
merged 1 commit into from
Aug 8, 2023
Merged

[3.x] [macOS] Backport notarytool, provisioning profile and PKG export options. #80239

merged 1 commit into from
Aug 8, 2023

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Aug 4, 2023

Back-port of #69638 and parts of #74644

Fixes #80213

@bruvzg bruvzg added this to the 3.x milestone Aug 4, 2023
@akien-mga akien-mga added the cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release label Aug 4, 2023
@akien-mga akien-mga modified the milestones: 3.x, 3.6 Aug 4, 2023
@bruvzg bruvzg marked this pull request as ready for review August 7, 2023 05:43
@bruvzg bruvzg requested review from a team as code owners August 7, 2023 05:43
@akien-mga akien-mga changed the title [macOS] Back-port notarytool, provisioning profile and PKG export options. [macOS] Backport notarytool, provisioning profile and PKG export options. Aug 7, 2023
akien-mga
akien-mga approved these changes Aug 7, 2023
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@akien-mga akien-mga changed the title [macOS] Backport notarytool, provisioning profile and PKG export options. [3.x] [macOS] Backport notarytool, provisioning profile and PKG export options. Aug 8, 2023
@akien-mga akien-mga merged commit da5c95c into godotengine:3.x Aug 8, 2023
13 checks passed
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Had a go at cherry-picking this for 3.5, it's not trivial, because it depends on other PRs which haven't been cherry-picked:

And possibly more which further improved upon that refactoring.

So this seems a bit risky to attempt for 3.5. If we want to provide notarytool for notarization in 3.5.3, this should likely be done specifically for 3.5 with the minimal amount of changes. Or we can just disable notarization by default in 3.5.3 and let users do it after the export manually.

@akien-mga akien-mga removed the cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release label Aug 18, 2023
@sszigeti
Copy link

Just got an email from Apple. I'm quoting the relevant part:

Notarizing software with altool was deprecated in Xcode 13, and the Apple notary service will no longer accept uploads from altool as of November 1, 2023.

Is it possible to get instructions for disabling notarization and doing it manually?

@akien-mga
Copy link
Member

Just got an email from Apple. I'm quoting the relevant part:

Notarizing software with altool was deprecated in Xcode 13, and the Apple notary service will no longer accept uploads from altool as of November 1, 2023.

Is it possible to get instructions for disabling notarization and doing it manually?

In the export preset configuration, set notarization/enable to false. It's actually the default value in 3.5.x.

@lawnjelly lawnjelly mentioned this pull request Sep 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
enhancement platform:macos topic:editor topic:export
Projects
None yet
Milestone
3.6
Development

Successfully merging this pull request may close these issues.
3 participants
@bruvzg @akien-mga @sszigeti