Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Horizontal split view for Filesystem Dock #80241

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Horizontal split view for Filesystem Dock #80241

merged 1 commit into from
Oct 3, 2023

Conversation

gamedevishard
Copy link
Contributor

filesystem_dock

filesystem_dock

@gamedevishard gamedevishard requested a review from a team as a code owner August 4, 2023 08:10
@dalexeev dalexeev added this to the 4.x milestone Aug 7, 2023
KoBeWi
KoBeWi reviewed Aug 24, 2023
View reviewed changes
editor/filesystem_dock.cpp Outdated Show resolved Hide resolved
KoBeWi
KoBeWi reviewed Sep 6, 2023
View reviewed changes
editor/filesystem_dock.cpp Outdated Show resolved Hide resolved
KoBeWi
KoBeWi reviewed Sep 6, 2023
View reviewed changes
editor/filesystem_dock.cpp Outdated Show resolved Hide resolved
KoBeWi
KoBeWi reviewed Sep 6, 2023
View reviewed changes
editor/filesystem_dock.cpp Outdated Show resolved Hide resolved
KoBeWi
KoBeWi reviewed Sep 6, 2023
View reviewed changes
editor/filesystem_dock.cpp Outdated Show resolved Hide resolved
KoBeWi
KoBeWi reviewed Sep 6, 2023
View reviewed changes
editor/filesystem_dock.cpp Outdated Show resolved Hide resolved
KoBeWi
KoBeWi reviewed Sep 6, 2023
View reviewed changes
editor/filesystem_dock.cpp Outdated Show resolved Hide resolved
KoBeWi
KoBeWi reviewed Sep 6, 2023
View reviewed changes
editor/filesystem_dock.cpp Outdated Show resolved Hide resolved
KoBeWi
KoBeWi approved these changes Sep 21, 2023
View reviewed changes
Copy link
Member

@KoBeWi KoBeWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine now. One concern is that when you switch between horizontal and vertical mode, the split will be wrong. Maybe we should keep it separately for 2 modes

@akien-mga akien-mga modified the milestones: 4.x, 4.2 Sep 21, 2023
@gamedevishard
Copy link
Contributor Author

Seems fine now. One concern is that when you switch between horizontal and vertical mode, the split will be wrong. Maybe we should keep it separately for 2 modes

Check now please

@KoBeWi
Copy link
Member

KoBeWi commented Sep 22, 2023

The split seems to be not remembered between sessions.
Set vertical split size and horizontal split size. Restart while the dock is in horizontal mode. The horizontal split will reset, while the vertical split will use the horizontal value. I didn't check the implementation, but they need to be stored in separate values.

@akien-mga akien-mga merged commit ff9b3dc into godotengine:master Oct 3, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks! And congrats for your first merged Godot contribution 🎉

@kitbdev kitbdev mentioned this pull request Oct 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AThousandShips AThousandShips AThousandShips left review comments

@KoBeWi KoBeWi KoBeWi approved these changes

Assignees
No one assigned
Labels
enhancement topic:editor
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
6 participants
@gamedevishard @KoBeWi @akien-mga @AThousandShips @Sauermann @dalexeev