-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vulkan: Fix sanitizers error with empty shader name #80288
Conversation
Please squash your commits into a single one, see here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine
Thanks for contributing. The fix looks correct, though check bruvzg's suggestion to make it better. Aside from this, there are a number of Git issues that need to be handled:
|
Note that you merged the remote into your branch, instead of rebasing, squashing, and amending the commit as I requested. So the PR now has 3 commits when it should be 1. |
2df9694
to
c83280d
Compare
c83280d
to
9b3b891
Compare
Co-authored-by: Rémi Verschelde <rverschelde@gmail.com>
9b3b891
to
77b0235
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Thanks! And congrats for your first merged Godot contribution 🎉 |
In drivers/vulkan/rendering_device_vulkan.cpp:4815 on editor start compiled with following options:
dev_build=yes debug_symbols=yes optimize=debug use_ubsan=yes use_asan=yes use_lsan=yes use_msan=yes
Whenever you use a low level functionality for compute shaders the shader name is nullptr on editor start.
This is non critical, as the length of the shader name is 0, no actual copy happens, though the sanitizers report this as a runtime error.