Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.x] Hierarchical culling: Add extra check to skeleton_attach_canvas_item #80325

Merged
merged 1 commit into from
Aug 15, 2023
Merged

[3.x] Hierarchical culling: Add extra check to skeleton_attach_canvas_item #80325

merged 1 commit into from
Aug 15, 2023

Conversation

lawnjelly
Copy link
Member

@lawnjelly lawnjelly commented Aug 6, 2023 •
edited
Loading

Although this check shouldn't be able to fail currently, it provides a small level of extra logic checking at only small cost in DEV builds.

Notes

@lawnjelly
Hierarchical culling - Add extra check to skeleton_attach_canvas_item
d7cca42 
Although this check shouldn't be able to fail currently, it provides a small level of extra logic checking at only small cost in DEV builds.
@lawnjelly lawnjelly added this to the 3.6 milestone Aug 6, 2023
@lawnjelly lawnjelly requested a review from a team as a code owner August 6, 2023 09:08
@lawnjelly lawnjelly mentioned this pull request Aug 6, 2023
Merged
@lawnjelly lawnjelly changed the title Hierarchical culling - Add extra check to skeleton_attach_canvas_item [3.x] Hierarchical culling - Add extra check to skeleton_attach_canvas_item Aug 6, 2023
clayjohn
clayjohn approved these changes Aug 9, 2023
View reviewed changes
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine

@akien-mga akien-mga changed the title [3.x] Hierarchical culling - Add extra check to skeleton_attach_canvas_item [3.x] Hierarchical culling - Add extra check to skeleton_attach_canvas_item Aug 9, 2023
@akien-mga akien-mga merged commit c685501 into godotengine:3.x Aug 15, 2023
13 checks passed
@akien-mga
Copy link
Member

Thanks!

@lawnjelly lawnjelly deleted the fti2d_check_skel_attach branch August 15, 2023 07:19
@akien-mga akien-mga changed the title [3.x] Hierarchical culling - Add extra check to skeleton_attach_canvas_item [3.x] Hierarchical culling: Add extra check to skeleton_attach_canvas_item Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clayjohn clayjohn clayjohn approved these changes

Assignees
No one assigned
Labels
enhancement topic:rendering topic:2d
Projects
None yet
Milestone
3.6
Development

Successfully merging this pull request may close these issues.
3 participants
@lawnjelly @akien-mga @clayjohn