Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use StringName consistently to refer to the Master audio bus name #80381

Merged
merged 1 commit into from
Aug 8, 2023
Merged

Use StringName consistently to refer to the Master audio bus name #80381

merged 1 commit into from
Aug 8, 2023

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Aug 7, 2023

These methods internally use StringName, so this should provide a minimal performance boost.

@Calinou Calinou requested review from a team as code owners August 7, 2023 15:44
@Calinou Calinou added this to the 4.x milestone Aug 7, 2023
YuriSizov
YuriSizov reviewed Aug 7, 2023
View reviewed changes
servers/audio_server.h Outdated Show resolved Hide resolved
YuriSizov
YuriSizov approved these changes Aug 7, 2023
View reviewed changes
Copy link
Contributor

@YuriSizov YuriSizov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the notes that I've left, this seems like a good idea to me.

@Calinou Calinou force-pushed the audio-bus-master-use-scenestringnames branch from a8c10a0 to 49b6067 Compare August 7, 2023 16:06
@akien-mga akien-mga modified the milestones: 4.x, 4.2 Aug 7, 2023
akien-mga
akien-mga approved these changes Aug 7, 2023
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine.

@akien-mga akien-mga merged commit 70e77a8 into godotengine:master Aug 8, 2023
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KoBeWi KoBeWi KoBeWi left review comments

@YuriSizov YuriSizov YuriSizov approved these changes

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
enhancement topic:core
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
4 participants
@Calinou @akien-mga @KoBeWi @YuriSizov