Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Fix infinite loop on EOF in the command line debugger #80400

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

timothyqiu
Copy link
Member

Backport of #78111 which is not easily cherry-pickable :P

When using the command line debugger (godot -d) on Unix systems, when
entering an EOF (ctrl+D), the debugger enters an infinite loop.

Adding a check for EOF in the debugger loop exits the debugger when EOF
is entered.

Fixes godotengine#50170.

(cherry picked from commit 4ecad8d)
@timothyqiu timothyqiu added this to the 3.6 milestone Aug 8, 2023
@timothyqiu timothyqiu requested a review from a team as a code owner August 8, 2023 05:30
@timothyqiu timothyqiu requested review from a team and removed request for a team August 8, 2023 05:31
@akien-mga akien-mga added the cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release label Aug 8, 2023
@akien-mga akien-mga merged commit 9435c38 into godotengine:3.x Aug 8, 2023
13 checks passed
@akien-mga
Copy link
Member

Thanks!

@timothyqiu timothyqiu deleted the eof-debugger branch August 8, 2023 13:50
@akien-mga
Copy link
Member

Cherry-picked for 3.5.3.

@akien-mga akien-mga removed the cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release label Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants