Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Fix AnimatedSprite normal map loading #80406

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

lawnjelly
Copy link
Member

@lawnjelly lawnjelly commented Aug 8, 2023

Normal map names are now correctly set up during loading.

Fixes #43435

Notes

  • Had never spotted this issue before, only took a couple mins to track down.
  • It's not really rendering, just a bit of code missing in the AnimatedSprite.

Normal map names are now correctly set up during loading.
@lawnjelly lawnjelly added this to the 3.6 milestone Aug 8, 2023
@lawnjelly lawnjelly requested a review from a team as a code owner August 8, 2023 08:45
@lawnjelly lawnjelly changed the title Fix AnimatedSprite normal map loading [3.x] Fix AnimatedSprite normal map loading Aug 8, 2023
@akien-mga akien-mga added the cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release label Aug 8, 2023
@akien-mga akien-mga merged commit 21ab700 into godotengine:3.x Aug 15, 2023
13 checks passed
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 3.5.3.

@akien-mga akien-mga removed the cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release label Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants