Document RenderingServer.get_video_adapter_name() may report a fixed name
#80445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d name Firefox will always report the user's GPU as a GeForce GTX 980 in an attempt to make fingerprinting more difficult. This is not the case in Chromium-based browsers though.
Calinou
force-pushed
the
doc-video-adapter-web-fixed-model
branch
from
6acbabb
to
c751f19
Compare
Calinou
added
enhancement
documentation
cherrypick:4.0
cherrypick:4.1
mhilbrunner
approved these changes
Aug 9, 2023
akien-mga
reviewed
Aug 9, 2023
| @@ -1450,6 +1450,7 @@ | |||
| <description> | |||
| Returns the name of the video adapter (e.g. "GeForce GTX 1080/PCIe/SSE2"). | |||
| [b]Note:[/b] When running a headless or server binary, this function returns an empty string. | |||
| [b]Note:[/b] On the web platform, some browsers such as Firefox may report a different, fixed GPU name such as "GeForce GTX 980" (regardless of the user's actual GPU model). This is done to make fingerprinting more difficult. | |||
There was a problem hiding this comment.
We'll need to unify the casing of "Web" vs "web", and define some guidelines.
$ rg -g"*.xml" " Web[, ]" | wc -l
45
$ rg -g"*.xml" " web[, ]" | wc -l
30
I think at least when referring to Godot's "Web" platform, it should be capitalized, like it is in OS.get_name().
Then maybe when referring to "the web", it can be lowercase.
Here with "the web platform", are we talking about the web as a platform, or Godot's "Web" platform?
There was a problem hiding this comment.
Here with "the web platform", are we talking about the web as a platform, or Godot's "Web" platform?
I'd say the latter, but I don't have a strong opinion on it.
There was a problem hiding this comment.
I guess this can/should be handled in a separate PR anyway, so let's merge this one.
akien-mga
approved these changes
Aug 16, 2023
|
Thanks! |
YuriSizov
removed
the
cherrypick:4.1
|
Cherry-picked for 4.1.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firefox may1 report the user's GPU as a GeForce GTX 980 in an attempt to make fingerprinting more difficult. This is not the case in Chromium-based browsers though.
Footnotes
I've noticed this on 3 different setups (GTX 1080, RX 6900 XT, RTX 4090). I don't know if GPUs older than the GTX 980 are affected by this (probably not). ↩