Fix TileSet with TileMap handling #80462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KoBeWi
force-pushed
the
tfw_your_bugfix_makes_things_worse
branch
from
5376d3c
to
f02133a
Compare
akien-mga
approved these changes
Aug 9, 2023
|
Thanks! |
This was referenced Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #80399
Regression from #74717
The PR force-edited the TileSet when the edited TileMap had one which, aside from still causing the error it tried to fixed, caused also the linked issue + clearing the TileSet in TileMap did not properly close the editor.
This PR makes the TileSet edited without using the standard editor's API. You can still "properly edit" the TileSet when you unfold the inspector property; it does not interfere with what TileMap plugin does.