Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify the behavior of CSGMesh using ArrayMesh #80543

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

mandryskowski
Copy link
Contributor

The docs for CSGMesh/CSGMesh3D should say that it ignores all vertex attribute arrays of ArrayMesh except position, uv1 and normal. I tried to use per-vertex color in a shader only to realise that it is not even used when creating the brush.

Compatible with 3.x.

CSGBrush *CSGMesh::_build_brush() {

return _create_brush_from_arrays(vertices, uvs, smooth, materials);
}

Copy link
Member

@fire fire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can tell, the description is accurate.

The "blast radius" is small so I'm approving this because it's a documentation change and not a code change.

@akien-mga akien-mga modified the milestones: 4.x, 4.2 Aug 14, 2023
@akien-mga akien-mga added cherrypick:3.x Considered for cherry-picking into a future 3.x release cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release labels Aug 14, 2023
@akien-mga akien-mga changed the title Clarify the behaviour of CSGMesh using ArrayMesh Clarify the behavior of CSGMesh using ArrayMesh Aug 14, 2023
@akien-mga akien-mga merged commit 06eaa8c into godotengine:master Aug 14, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.3.

@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherrypick:3.x Considered for cherry-picking into a future 3.x release documentation enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants