Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash on exit where TileSet calls destroyed TileSetAtlasSourceEditor #80607

Merged
merged 1 commit into from
Aug 14, 2023
Merged

Fix crash on exit where TileSet calls destroyed TileSetAtlasSourceEditor #80607

merged 1 commit into from
Aug 14, 2023

Conversation

lawnjelly
Copy link
Member

Removes signal from TileSet on destroying TileSetAtlasSourceEditor, to prevent TileSet calling function in destroyed TileSetAtlasSourceEditor.

Fixes #80088

Notes

  • See linked issue for more description of the problem.
  • I'm not very familiar with master or these classes, but this fixes the crash.

@lawnjelly
Fix crash on exit where TileSet calls destroyed TileSetAtlasSourceEditor
fa7be20 
Removes signal from TileSet on destroying TileSetAtlasSourceEditor, to prevent TileSet calling function in destroyed TileSetAtlasSourceEditor.
@lawnjelly lawnjelly added this to the 4.x milestone Aug 14, 2023
clayjohn
clayjohn approved these changes Aug 14, 2023
View reviewed changes
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@clayjohn clayjohn modified the milestones: 4.x, 4.2 Aug 14, 2023
@akien-mga akien-mga requested a review from KoBeWi August 14, 2023 09:50
@akien-mga akien-mga merged commit c2fde9c into godotengine:master Aug 14, 2023
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@lawnjelly lawnjelly deleted the fix_tileset_signal_crash branch August 14, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KoBeWi KoBeWi KoBeWi approved these changes

@clayjohn clayjohn clayjohn approved these changes

Assignees
No one assigned
Labels
bug crash topic:editor
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

TileSet-related crash when closing the editor
4 participants
@lawnjelly @akien-mga @KoBeWi @clayjohn