-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add motion vector support for animated surfaces #80618
Add motion vector support for animated surfaces #80618
Conversation
There's a few possible solutions to that. Currently the one swapping the buffers is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple comments from code review
servers/rendering/renderer_rd/shaders/forward_clustered/scene_forward_clustered.glsl
Outdated
Show resolved
Hide resolved
716b1c5
to
1bbad6d
Compare
Submitting for review, we might want some more extensive testing to spot any other issues if they arise. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the one nitpicky comment. Otherwise this looks great! Tested locally and it works well
…nd shapes. Extends mesh instances that required custom vertex buffers to create two alternating buffers that are written to and binds them to use them as the previous vertex buffer when generating motion vectors.
1bbad6d
to
e2984af
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I tested locally and everything works.
While I don't anticipate any issues, I think the scope of changes is large enough that we shouldn't cherrypick this into 4.1
Thanks! |
Extends mesh instances that required custom vertex buffers to create two alternating buffers that are written to and binds them to use them as the previous vertex buffer when generating motion vectors.
Looking for some input on some of the implementation decisions.