Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to get a list of visible embedded Windows #80673

Merged
merged 1 commit into from
Aug 16, 2023
Merged

Allow to get a list of visible embedded Windows #80673

merged 1 commit into from
Aug 16, 2023

Conversation

YeldhamDev
Copy link
Member

While it's currently possible to manipulate Windows that are native (via DisplayServer.window_*() methods), there are no ways to get which embedded windows are being used. This PR creates the get_embedded_subwindows() method for the Viewport, that lists all visible embedded windows tied to one.

@YeldhamDev YeldhamDev added this to the 4.2 milestone Aug 16, 2023
@YeldhamDev YeldhamDev requested review from a team as code owners August 16, 2023 01:13
Sauermann
Sauermann approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@Sauermann Sauermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation looks correct. Also I have tested, that the functionality works.
I would probably move the code to the other subwindow-functions, like Viewport::is_embedding_subwindows.
Can't say anything about the topic, if the functionality is needed.

@YeldhamDev YeldhamDev force-pushed the give_me_my_windows! branch from b7d5304 to de27df5 Compare August 16, 2023 13:42
@YeldhamDev
Copy link
Member Author

@Sauermann

I would probably move the code to the other subwindow-functions, like Viewport::is_embedding_subwindows.

Good idea, I've done so.

@akien-mga akien-mga merged commit 77fd8f3 into godotengine:master Aug 16, 2023
@akien-mga
Copy link
Member

Thanks!

@YeldhamDev YeldhamDev deleted the give_me_my_windows! branch August 16, 2023 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sauermann Sauermann Sauermann approved these changes

Assignees
No one assigned
Labels
enhancement topic:core
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
3 participants
@YeldhamDev @akien-mga @Sauermann