-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing RenderingDevice method descriptions #80716
Add missing RenderingDevice method descriptions #80716
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution! Some phrasing and grammar details
0d948ef
to
1740366
Compare
Thanks for the quick review @AThousandShips . I fixed those issues and committed your suggestions. I also squashed the suggestion commit back into one commit :D |
Great! I'm not exactly sure of the exact wordings and someone else will come around as well to review it, just added some suggestions on things where I thought it'd help |
Yes those were some good suggestions. Especially the "ranging" stuff ^^ Also my bad for having a typo in the first place. I forgot to set up my pre commit hooks properly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested some things I randomly noticed
6e58819
to
d57eb81
Compare
Alright added all your suggestions too @RedMser . Thanks for looking over it ^^ |
176a89b
to
e398533
Compare
Alright, once again merged everything together. I also removed the double space after "clearing" (as mentioned by @akien-mga ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Good work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer "Prints an error" as opposed to "Throws an error", as Godot doesn't use exceptions.
Looks good! Could you squash the commits? See PR workflow for instructions. |
e0058b1
to
41daf29
Compare
41daf29
to
bd4d430
Compare
Alright! I think I got everything right now. When trying to commit the changes @Calinou suggested, I must have messed something up and had a bunch of other commits in my branch history. TLDR: My faults are fixed now and everything should be correct now. |
Thanks! |
Cherry-picked for 4.1.3. |
I went through the RenderingDevice.xml file and added all the missing descriptions of methods. I also updated some descriptions to be more complete.
This is in an effort to become more familiar with the Godot source code, specifically compute shaders.