Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a RegEx icon #80724

Merged
merged 1 commit into from
Aug 17, 2023
Merged

Add a RegEx icon #80724

merged 1 commit into from
Aug 17, 2023

Conversation

MewPurPur
Copy link
Contributor

image

RegEx as a concept has an official icon already, so I used it. Didn't come up with anything to use for RegEx match though 🤔

@MewPurPur MewPurPur requested a review from a team as a code owner August 17, 2023 14:44
@AThousandShips AThousandShips added this to the 4.x milestone Aug 17, 2023
@akien-mga
Copy link
Member

akien-mga commented Aug 17, 2023 •
edited
Loading

Didn't come up with anything to use for RegEx match though

Maybe (.*)? ( ) creates a match group for what's inside.

@MewPurPur
Copy link
Contributor Author

MewPurPur commented Aug 17, 2023 •
edited
Loading

@akien-mga Doned. I haven't compiled to show how it looks in the engine, but it's this:

image

@akien-mga akien-mga modified the milestones: 4.x, 4.2 Aug 17, 2023
@akien-mga akien-mga merged commit 1c0e2e5 into godotengine:master Aug 17, 2023
@akien-mga
Copy link
Member

Thanks!

@MewPurPur MewPurPur deleted the regex-icon branch August 17, 2023 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YeldhamDev YeldhamDev YeldhamDev approved these changes

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
enhancement topic:editor
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
4 participants
@MewPurPur @akien-mga @YeldhamDev @AThousandShips