Remove error print from XRServer.find_interface
#80730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsnopek
approved these changes
Aug 17, 2023
Co-authored-by: David Snopek <dsnopek@gmail.com>
aaronfranke
force-pushed
the
xr-find-interface
branch
from
7ad2942 to
4310d49
Compare
m4gr3d
approved these changes
Aug 17, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the error print from the
XRServer.find_interface()method. It is a valid (and expected?) workflow to check if an interface exists by running this method, so we should not print an error, just return null.Also, this PR simplifies the logic, since
int idxis not needed.