[Android] Change the default "org.godotengine" package name to "com.example"

[adamscott]

Currently, we suggest to users the package name org.godotengine.<name-of-the-game> for Android builds.

Unfortunately, that makes it so that some users publish those games (with these package names) in the Play Store. That makes it seem like the game comes from the Godot Engine team itself.

I suggest to change the default to com.example. http://example.com/ is an example domain by design. So we should use that. It conveys the idea that you should maybe change that value before you ship a game.

I don't know if it would affect users that currently use org.godotengine.<name-of-the-game> as the package name of their games, but I think they shouldn't use that package name in the first case.

Edit: use com.example. instead of org.example.

[akien-mga]

This defeats the purpose of this default value.

Note $genname in org.godotengine.$genname - this is used to generate a valid identifier based on the project name. Since we can't make up a domain name for the user, we offer org.godotengine as the base for such auto-generated project identifiers.

If we decide that we don't want this behavior anymore after thousands of games have been published with it, then we should drop the whole $genname logic. There's no point generating names like org.example.myproject.

[adamscott]

There's no point generating names like org.example.myproject.

I don't agree. It displays how the package names work, how they intend to be used. And it doesn't prevent the build of a game, if you want to test quickly and if you don't have time to decide which package name to give to the project.

[m4gr3d]

I have no strong opinions either way, but the way it's phrased I'm curious whether this is an actual issue.. The Play Store is good at pointing out the developer(s) of an app / game (we had users calling out the fact that the Android editors were not originally published by an 'official' Godot account), so I don't think the package name creates much confusion especially as it's also not easily visible on an app / game landing page.

That said, Android Studio also follows the pattern com.example.<name_of_app> (see screenshot below), so switching seems also fine.

[aaronfranke]

Since this changes behavior, I would suggest removing both the 4.0 and 4.1 cherrypick labels. Changing behavior in minor releases makes sense, but it's not a good idea to change behavior in a patch release.

[akien-mga]

Since this changes behavior, I would suggest removing both the 4.0 and 4.1 cherrypick labels. Changing behavior in minor releases makes sense, but it's not a good idea to change behavior in a patch release.

Indeed, even in 4.2, this will break compatibility for users who relied on this, as their game identifier will change.

[adamscott]

Here's a conversation that happened today in the GodotCon Discord.

[YuriSizov]

I think the name can also be visible in user-facing logs (crash logs?), which may mislead users into contacting us for support with games, if the developer never provided any other means of reaching them.

[akien-mga]

I would go with "com.example." like Android Studio, instead of "org.example.".

[adamscott]

I would go with "com.example." like Android Studio, instead of "org.example.".

I'll update the PR.

[akien-mga]

Thanks!