Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Path3D gizmo usability #80802

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Improve Path3D gizmo usability #80802

merged 1 commit into from
Oct 3, 2023

Conversation

xiongyaohua
Copy link
Contributor

@xiongyaohua xiongyaohua commented Aug 20, 2023 •
edited
Loading

Allow change tilt gizmo color and size in editor setting, following this comment from @TokageItLab .

Screenshot 2023-08-20 at 11 37 34

@xiongyaohua xiongyaohua requested a review from a team as a code owner August 20, 2023 03:22
@xiongyaohua xiongyaohua force-pushed the path3d_gizmo_usability branch from 3804b2b to ba794e9 Compare August 20, 2023 03:36
@TokageItLab
Copy link
Member

Can you change the color on the Tilt handle (line between curve point and tilt point)? That is easily confused with InOutHandle.

@TokageItLab
Copy link
Member

After, the image has now been updated. It looks fine.

TokageItLab
TokageItLab approved these changes Aug 20, 2023
View reviewed changes
Copy link
Member

@TokageItLab TokageItLab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the features look good, but I'm a little concerned about whether this is the right place to define the retrieved values (considering that they should be cached and the time to update the EditorSetting). It would be better to ask @YuriSizov to review that.

@TokageItLab TokageItLab requested a review from YuriSizov August 20, 2023 03:47
@TokageItLab TokageItLab added this to the 4.2 milestone Aug 20, 2023
@xiongyaohua xiongyaohua force-pushed the path3d_gizmo_usability branch from ba794e9 to 49df844 Compare August 23, 2023 02:34
@xiongyaohua xiongyaohua force-pushed the path3d_gizmo_usability branch from 49df844 to 183a3db Compare September 16, 2023 07:55
@YuriSizov YuriSizov removed their request for review September 29, 2023 12:04
@YuriSizov
Copy link
Contributor

@xiongyaohua Bump :) Please see the feedback above!

@xiongyaohua xiongyaohua force-pushed the path3d_gizmo_usability branch from 183a3db to 2f265e4 Compare October 2, 2023 09:06
@xiongyaohua xiongyaohua requested a review from akien-mga October 2, 2023 09:14
@xiongyaohua
Copy link
Contributor Author

Bump :) Please see the feedback above!

Sorry, been busy recently. Fixed.

@xiongyaohua
Improve Path3D gizmo usability
ce4f645 
Allow change tilt gizmo color and size in editor setting
@xiongyaohua xiongyaohua force-pushed the path3d_gizmo_usability branch from 2f265e4 to ce4f645 Compare October 3, 2023 01:56
akien-mga
akien-mga approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me.

@akien-mga akien-mga merged commit cb4879a into godotengine:master Oct 3, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@morganholly
Copy link

changing the setting doesn't seem to be persisted between editor opens and also doesn't affect the gizmo. also the gizmo is unusable for me. i did convert a copy of a 4.1.1 project to test with, and it seemed to not convert all meshes, so perhaps that is related

@YuriSizov
Copy link
Contributor

changing the setting doesn't seem to be persisted between editor opens and also doesn't affect the gizmo.

Please open a bug report about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuriSizov YuriSizov YuriSizov left review comments

@TokageItLab TokageItLab TokageItLab approved these changes

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
enhancement topic:editor topic:3d usability
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
5 participants
@xiongyaohua @TokageItLab @YuriSizov @akien-mga @morganholly