Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid creating any useless undo action when dragging nodes in place #80817

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

garychia
Copy link
Contributor

@garychia garychia commented Aug 20, 2023

Fixes #80707

Update: the solution is updated for situations where multiple nodes are dragged in place.

@garychia garychia requested a review from a team as a code owner August 20, 2023 12:59
@AThousandShips AThousandShips added this to the 4.x milestone Aug 20, 2023
@KoBeWi
Copy link
Member

KoBeWi commented Aug 25, 2023

Can still happen with multiple nodes.

godot.windows.editor.dev.x86_64_2IDxum7w2G.mp4

@garychia garychia changed the title Avoid creating any useless undo action when dragging a node in place Avoid creating any useless undo action when dragging nodes in place Aug 26, 2023
@garychia garychia force-pushed the reparent_node branch 2 times, most recently from 586f19a to 8da4455 Compare August 26, 2023 13:56
@YuriSizov YuriSizov modified the milestones: 4.x, 4.2 Aug 31, 2023
@akien-mga akien-mga requested a review from KoBeWi September 25, 2023 22:07
@akien-mga akien-mga merged commit fc64dfe into godotengine:master Oct 10, 2023
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dragging node in place creates useless undo action
5 participants