Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve PackedScene unit test by covering more methods #80819

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Improve PackedScene unit test by covering more methods #80819

merged 1 commit into from
Jan 4, 2024

Conversation

sepTN
Copy link
Contributor

@sepTN sepTN commented Aug 20, 2023

Adding additional unit test for PackedScene for these methods:

  • set_path()
  • replace_state()
  • recreate_state()

Link back to #43440

@sepTN sepTN requested a review from a team as a code owner August 20, 2023 14:11
@AThousandShips AThousandShips added this to the 4.x milestone Aug 20, 2023
Geometror
Geometror approved these changes Jan 4, 2024
View reviewed changes
Copy link
Member

@Geometror Geometror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@akien-mga akien-mga modified the milestones: 4.x, 4.3 Jan 4, 2024
@akien-mga akien-mga merged commit 8ac6742 into godotengine:master Jan 4, 2024
@akien-mga
Copy link
Member

Thanks!

@Calinou Calinou mentioned this pull request Feb 21, 2024
Open
99 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Geometror Geometror Geometror approved these changes

Assignees
No one assigned
Labels
enhancement topic:tests
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
4 participants
@sepTN @akien-mga @Geometror @AThousandShips