Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Propagate error code when glue generation fails #80846

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

akien-mga
Copy link
Member

This used to be ignored as we ran the X11 version with Vulkan software renderer and xvfb-run, which could crash at the time. Now that we have headless mode, this is not a problem anymore.

This used to be ignored as we ran the X11 version with Vulkan software renderer and xvfb-run, which could crash at the time. Now that we have headless mode, this is not a problem anymore.
@akien-mga akien-mga added enhancement topic:buildsystem topic:dotnet cherrypick:4.0 cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release labels Aug 21, 2023
@akien-mga akien-mga added this to the 4.2 milestone Aug 21, 2023
@akien-mga akien-mga requested a review from a team August 21, 2023 11:22
@akien-mga akien-mga requested a review from a team as a code owner August 21, 2023 11:22
@akien-mga akien-mga changed the title CI: Propagated error code when glue generation fails CI: Propagate error code when glue generation fails Aug 21, 2023
Copy link
Member

@aaronfranke aaronfranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

@akien-mga akien-mga merged commit 170ae3a into master Aug 21, 2023
30 checks passed
@akien-mga akien-mga deleted the ci-mono-glue-fail-condition branch August 21, 2023 17:33
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.2.

@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants