Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert to the old Camera icons #80865

Merged
merged 1 commit into from
Aug 22, 2023
Merged

Conversation

MewPurPur
Copy link
Contributor

@MewPurPur MewPurPur commented Aug 21, 2023

People weren't very in favor of the new camera icons according to Juan's twitter poll, for many reasons, mainly:

  • The film camera was a very good analogy for how the camera continuously looks at a region in the game world, while the new camera suggests you snap it to take a photo.
  • The reason for the change was direction-neutrality, but the new icon was still not completely neutral, looking at the viewer.
  • People aren't used to it and we shouldn't change user expectations unless the improvement is clear to everyone.

Agreed with Calinou (original PR author) on the following:

  • We revert all icons to their old state...
  • But we keep CameraTexture, as it represents a physical camera attached to your device. Calinou's camera type will now be the mascot of external cameras.
  • We also do a small change to GizmoCamera, removing its insides so it's more see-through.
  • We also keep the idea of CameraAttributesPhysical and CameraAttributesPractical. I swapped the asterisk colors because I noticed blue is often used for physics-related classes.
  • We remove the now unused ClippedCamera.

@MewPurPur MewPurPur requested a review from a team as a code owner August 21, 2023 23:10
@Calinou Calinou added this to the 4.x milestone Aug 21, 2023
@akien-mga akien-mga modified the milestones: 4.x, 4.2 Aug 21, 2023
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No strong opinion personally, so let's follow the user feedback :)

Copy link
Member

@aaronfranke aaronfranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The gizmo icon seems kinda weird to me, but overall I think this PR is an improvement.

I think it would make sense to have the old gizmo icon, and just... tell people it doesn't indicate direction. Maybe we need to make the wireframe bigger when you zoom out to avoid the problem? Anyway, I'm not sure how to best solve that problem, I just like the old icon better.

@akien-mga akien-mga merged commit b195b0a into godotengine:master Aug 22, 2023
@akien-mga
Copy link
Member

Thanks!

@MewPurPur
Copy link
Contributor Author

Same as Aaron honestly

@MewPurPur MewPurPur deleted the cam-revert branch August 22, 2023 08:34
@JekSun97
Copy link
Contributor

JekSun97 commented Sep 5, 2023

Oh, it's a pity, I already managed to fall in love with them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants