[Windows] Add main executable to the console wrapper dependencies to prevent simultaneous linking. #80918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…prevent simultaneous linking.
|
cc @darksylinc @anvilfolk Could you give it a test and see if this PR resolves your issue? |
|
I compiled from scratch twice on the computer that was having trouble pretty regularly and it worked fine! It's not a 100% guarantee, but it is a good indicator that this fix might work! :) |
|
Three more successful compilations with no issues whatsoever. I'd say merge :) |
YuriSizov
approved these changes
Aug 24, 2023
|
Thanks! |
akien-mga
added
cherrypick:3.x
|
Cherry-picked for 4.1.2. |
YuriSizov
removed
the
cherrypick:4.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #80482 (comment)