Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add px suffix for TileSet separation property #80934

Merged
merged 1 commit into from
Aug 25, 2023

Conversation

philippesic
Copy link
Contributor

Add px suffix to TileMap > TileSet > Selection > Seperation. Visual change.

Fixes #80869

@AThousandShips
Copy link
Member

You have several unrelated changes in your PR, please squash your commits into one, see here

Copy link
Member

@AThousandShips AThousandShips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minus the cleaning of the commit history this looks good

@dalexeev
Copy link
Member

#80869 (comment):

TileSet->Select is this Animation Separation "px" too? idk
I tried setting up animation separation and got a not enough room error, so maybe not "px". idk

p_list->push_back(PropertyInfo(Variant::VECTOR2I, PNAME("animation_separation")));

property_info = PropertyInfo(Variant::INT, "animation_separation", PROPERTY_HINT_NONE, "", PROPERTY_USAGE_NO_EDITOR);

@dalexeev dalexeev changed the title TileSet Seperation Suffix Add px suffix for TileSet separation property Aug 23, 2023
@philippesic
Copy link
Contributor Author

Squashed unrelated commits

@YuriSizov
Copy link
Contributor

Could you please amend your commit message? We don't use the "fix", "chore", etc prefixes as per the project's preferred style. Just dropping it would be fine.

TileSet->Select is this Animation Separation "px" too? idk

Documentation says it's in "grid tiles".

Add px suffix to TileSet separation value
@YuriSizov YuriSizov merged commit 43f6183 into godotengine:master Aug 25, 2023
@YuriSizov
Copy link
Contributor

Thanks! And congrats on your first merged Godot PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TileSet Separation missing "px" like similar values?
5 participants