Deselect multi caret when alt clicking on it #80956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcusElg
force-pushed
the
deselectmulticaret
branch
from
a7f69f2 to
4f1bc7d
Compare
MewPurPur
approved these changes
Aug 24, 2023
KoBeWi
approved these changes
Aug 24, 2023
AThousandShips
approved these changes
Aug 24, 2023
Calinou
reviewed
Aug 24, 2023
There was a problem hiding this comment.
Tested locally (rebased on top of master 6758a7f), it mostly works as expected.
However, with this PR, unlike in VS Code, it's not possible to deselect a character/word selection by holding Alt and clicking the selection or the caret:
simplescreenrecorder-2023-08-25_00.08.55.mp4
MarcusElg
force-pushed
the
deselectmulticaret
branch
from
4f1bc7d to
a67965e
Compare
Paulb23
reviewed
Aug 28, 2023
MarcusElg
force-pushed
the
deselectmulticaret
branch
from
a67965e to
732c395
Compare
|
@Calinou fixed, you can now deselect by clicking its selection |
Paulb23
requested changes
Sep 3, 2023
MarcusElg
force-pushed
the
deselectmulticaret
branch
from
732c395 to
2ecbac3
Compare
MarcusElg
force-pushed
the
deselectmulticaret
branch
from
2ecbac3 to
aac1070
Compare
Paulb23
approved these changes
Sep 10, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #80895
If a caret can't be added it checks if it already exists and then removes it. So now it works similarly to vscode when alt clicking once adds a caret, and alt clicking again removes it.
It does loop through the carets twice but preventing that would require changing the return value of add_caret and therefore break compatibility. The amount of carets are always quite low so the performance impact should be neglectable.