FileSystemDock: Don't update current path on rename when file list has focus #81007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demo.mp4 |
|
It might be good if we don't lose currently highlighted folder in the tree view after rename. |
fire
changed the title
akien-mga
changed the title
|
Needs rebase. |
|
tested on master issue still exist. |
FileSystemDock: Don't update current path and path edit when the file list has focus. So that when renaming from the file list, we don't cd into the renamed folder automatically.
KoBeWi
approved these changes
Oct 1, 2023
This comment was marked as resolved.
This comment was marked as resolved.
|
Its back now. |
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #80940
FileSystemDock: Don't update current path and path edit when the file list has focus. So that when renaming from the file list, we don't cd into the renamed folder automatically.